Fix potential crash in FileReader.readAsArrayBuffer on malformed data URL#56382
Fix potential crash in FileReader.readAsArrayBuffer on malformed data URL#56382Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Conversation
… URL When reading as ArrayBuffer, the code splits the data URL on "," and accesses index [1] without a fallback. If the native module returns a string without a comma, this results in undefined being passed to toByteArray(), causing a crash. Added nullish coalescing to default to an empty string.
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Nedunchezhiyan-M
force-pushed
the
fix/filereader-base64-null-safety
branch
from
e553a3d to
497e112
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
the
Shared with Meta
1 participant
Summary
Fix a potential crash in
FileReader.readAsArrayBuffer()when the native module returns a data URL string without a comma separator. The code splits on,and accesses index[1]without checking if it exists, which would passundefinedtotoByteArray()and crash.Added a nullish coalescing fallback to default to an empty string.
Changelog:
[GENERAL] [FIXED] - Fix potential crash in FileReader.readAsArrayBuffer when data URL has no comma separator
Test Plan